【Abondoned for commit too large】:decoupling apiserver and clustersynchro-manager by message midd… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,13 +51,32 @@ type Options struct { | |||
| KubeStateMetrics *kubestatemetrics.Options | |||
|
|
|||
| WorkerNumber int // WorkerNumber is the number of worker goroutines | |||
| Publisher *watchoptions.MiddlerwareOptions | |||
There was a problem hiding this comment.
middleware to messagequeue？
There was a problem hiding this comment.
middleware better
|
|
||
| options.BindLeaderElectionFlags(&o.LeaderElection, genericfs) | ||
|
|
||
| fs := fss.FlagSet("misc") | ||
| fs.StringVar(&o.Master, "master", o.Master, "The address of the Kubernetes API server (overrides any value in kubeconfig).") | ||
| fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path to kubeconfig file with authorization and master location information.") | ||
| fs.StringVar(&o.Kubeconfig, "manager-kubeconfig", o.Kubeconfig, "Path to kubeconfig file with authorization and master location information.") |
There was a problem hiding this comment.
why do you modify the current kueconfig key
There was a problem hiding this comment.
ok, i will fix it.
| "strings" | ||
| ) | ||
|
|
||
| func GetShardingTable(gvr schema.GroupVersionResource) string { |
There was a problem hiding this comment.
What does GetShardingTable work for
|
please run make lint on your local Desktop |
zhouhaoA1
force-pushed
the
dev_messagequeue
branch
16 times, most recently
from
1eb08d9
to
4177173
Compare
zhouhaoA1
force-pushed
the
dev_messagequeue
branch
2 times, most recently
from
7eebc7d
to
21084f6
Compare
…leware Signed-off-by: zhouhaoA1 <[email protected]>
zhouhaoA1
force-pushed
the
dev_messagequeue
branch
from
21084f6
to
8538dc6
Compare
zhouhaoA1
changed the title
zhouhaoA1
force-pushed
the
main
branch
2 times, most recently
from
d799fb3
to
bf2a5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…leware
What type of PR is this?
/kind feature
What this PR does / why we need it:
decoupling apiserver and clustersynchro-manager by message middware
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: